Closed x1k84 closed 4 months ago
@x1k84 Thanks for the PR. I'll review this properly soon, although I have some quick, off-the-cuff feedback right now: Can you have this second commit be a second PR, please? Can you also avoid style changes, unless you need to change the semantics of the code anyway? I'd welcome style changes affecting lots of code at once, as long as those changes are enforced by CI. Actually, there's a ticket for it: #296. Again, to make the code easier to review, those sorts of style changes should be a separate PR. So this one PR could really be broken into two and a bit.
Actually I took a closer look at the second commit and it appears to be just style changes, despite the commit message saying that it changes the behavior of the inbox
@x1k84 Thanks for the PR. I'll review this properly soon, although I have some quick, off-the-cuff feedback right now: Can you have this second commit be a second PR, please? Can you also avoid style changes, unless you need to change the semantics of the code anyway? I'd welcome style changes affecting lots of code at once, as long as those changes are enforced by CI. Actually, there's a ticket for it: #296. Again, to make the code easier to review, those sorts of style changes should be a separate PR. So this one PR could really be broken into two and a bit.
Sorry, I didn't mean to include that second one. I'm not sure what happened. It wasn't finished yet anyway.
This change enhances user experience by providing a smoother and more immediate interaction with the page content.