duolicious / duolicious-frontend

The frontend of the Duolicious dating app
https://duolicious.app/
GNU Affero General Public License v3.0
34 stars 15 forks source link

Clubs are case sensitive #383

Open Raton-Laveur opened 3 months ago

Raton-Laveur commented 3 months ago

Example: "yakuza" and "Yakuza" are two different clubs, with different member count.

Is this by design?

duogenesis commented 3 months ago

This was deliberate, though I think I should've disallowed upper case letters. My thought was that some terms have very different meanings depending on their capitalization. Example:

Though in practice, making different capitalisations distinct seems to have caused more confusion than it saved. The most popular club is "Anime", with 3503 members. But then there's also an "anime" club with 119 members.

I'd be happy to accept a PR which transforms upper case letters in club names into lower case letters. That means that lots of clubs will need to coalesce, though it's possible to do with a single query involving the club and person_club tables, which can go here.