Upgrade deps to 2.0 and Generate icons from @phosphor/core

[mrkpatchaa]

This will help in reducing number of files in this repo + upgrade to the most recent versions of icons.

• Generate icons from @phosphor-icons/core -> use latest version a.k.a. 2.x. (Fixes #27 )
• Add classname to generated components (Fixes #26)
• Upgrade dependencies
• Upgrade example app to use latest version of expo (49)

[mrkpatchaa]

@jhhayashi can you check this ?

[jacesimons14]

Would love to see this merged!!!!

[mrkpatchaa]

In the meantime I published this npm package https://www.npmjs.com/package/@mrkpatchaa/phosphor-react-native with the latests updates. I'll take id down once this PR is merged.

[jacesimons14]

sick thanks dude you're a king

[jacesimons14]

@mrkpatchaa I might just be an idiot, does your package require other dependencies? I'm seeing this

[mrkpatchaa]

Oh let me check. The typescript types are not pushed to npm.

[mrkpatchaa]

@jacesimons14 can you check version 2.0.1? I fixed the types issue. Old version (this package)

Current version (my package)

I also updated this PR with the fixes.

[jacesimons14]

@mrkpatchaa npm says there hasn't been a new version for 4 days

[jacesimons14]

still 2.0.0

[mrkpatchaa]

@jacesimons14 maybe cache? This is the latest version on npm. You can install the package again or run npm update to get the last version.

[jacesimons14]

Ah I see it now, thank you, works great so far!

[daxaxelrod]

Would love this. Have been running into issues where some icons are not available here but they are for the web package so this would be great

[jhhayashi]

@jhhayashi can you check this ?

Hey there! I'm not affiliated with this repo, but happy to help where I can.

This PR is a little too large to review. Would it be possible to split it into a few smaller ones?

[mrkpatchaa]

@jhhayashi it's only "large" because of the deleted files that are not needed anymore. I am generating icons directly from phospor/core.

You can filter them out in the view. If you wish I can put them back and make the cleanup afterwards.

[mrkpatchaa]

@jhhayashi I just pushed a new commit to revert the deletions. I will create another one for the deletion.

[mrkpatchaa]

I just created the companion PR for this. #35

[mrkpatchaa]

Would love this. Have been running into issues where some icons are not available here but they are for the web package so this would be great

@daxaxelrod You can use the npm package I published as a temporary solution... https://github.com/duongdev/phosphor-react-native/pull/33#issuecomment-1669682761

[mrkpatchaa]

@duongdev @Joeao @kingdavidmartins @bkdev98 are you guys able to check this and merge? I created another npm package as a temporary solution but might be interesting to update this repo.

[DavidP-B]

In the meantime I published this npm package https://www.npmjs.com/package/@mrkpatchaa/phosphor-react-native with the latests updates. I'll take id down once this PR is merged.

I'm using your library meanwhile this PR is accepted. I've founded that you maybe forgot to import FileSearch icon... I'm using this icon but when I change to your library I can't see it.

[mrkpatchaa]

@DavidP-B I just checked and file-search is an alias for file-magnifying-glass -> https://github.com/phosphor-icons/core/blob/main/bin/index.js Maybe it would be interresting to add this as well in this PR. I'll try to find some time to do it this week. Anyway, seems like the repo is not maintained anymore. I couldn't get anyone to merge this 😕

[duongdev]

Thank you @mrkpatchaa @DavidP-B and @jacesimons14 for your contribution. I am not currently work with React Native but your efforts on this library is so incredible!

[mrkpatchaa]

Thank you @mrkpatchaa @DavidP-B and @jacesimons14 for your contribution. I am not currently work with React Native but your efforts on this library is so incredible!

Hi @duongdev and happy to finally hear from you 😄 What are the plans to continue maintaining the project? I can help if you want. In the meantime, with the new approach, it will require less work to maintain. Think also about the option of moving it to @phospor community?

[jhhayashi]

Hey @mrkpatchaa!

@duongdev got me set up on this repo (see #34), so I'll now be able to help out with the maintenance. I have an active project that depends on this library, so I'll make sure to keep things maintained

[mrkpatchaa]

Understood @jhhayashi . I also have an active project using it. Feel free to let me know if you need help on something. Good luck mate.

[jhhayashi]

Thanks for the patience; v2.0.0 has been released on npm

[mrkpatchaa]

I will then remove @mrkpatchaa/phosphor-react-native from npm. Thanks.