search

duongdev / phosphor-react-native

phosphor-icons for react-native. A flexible icon family for React Native
https://www.npmjs.com/package/phosphor-react-native
MIT License
174 stars 21 forks source link

Help with maintenance? #34

Closed jhhayashi closed 9 months ago

jhhayashi commented 10 months ago

Hey Dustin, thanks for all of the work putting together this library.

This library is linked to from the phosphor icon README, so it would be helpful to better understand your willingness to maintain and host it.

If you'd like to keep hosting the repo, but are looking for help maintaining it, I'd be happy to help. If you're no longer interested in hosting the repo, I'd also volunteer to take it (and the npm releases) over.

duongdev commented 9 months ago

Hi @jhhayashi, thank for your willingness to help maintaining this repo. Very appreciated 🙇 I love this project and really want to actively maintain it. Unfortunately, I don't have any React Native project atm and don't have time to keep it up-to-date. So it would be great if you can help me maintain this repo.

I will add you as maintainer for this repo. Please also give me your npmjs user ID, I will add you as npm package maintainer too.

Thanks!

jhhayashi commented 9 months ago

Sounds great. I have an active project that depends on this project, so I'm excited to help.

My npmjs user ID is jhhayashi

jhhayashi commented 9 months ago

I got both invites and should be all set up 🚀

duongdev commented 9 months ago

Cool. Could you please help release the latest changes to npm? Thank you! 🎉

jhhayashi commented 9 months ago

Yep, will do!

jhhayashi commented 9 months ago

@duongdev are you able to approve my open PRs and/or grant me push access to the repo? I won't be able to do a tag push after an npm release

duongdev commented 9 months ago

@jhhayashi As this repo belongs to my personal Github account, I can only add you as collaborator. Because we have a protected branch rule on main, its PRs need to have at least 1 approval to be merged. I can remove that requirements so perhaps you can merge your PRs without my approval.

jhhayashi commented 9 months ago

Got it. The one issue there is that if we use PRs to update the package.json version after a release, the commit hash will change when merging and the tag will be referencing the commit on the PR rather than the commit that lands in the main branch. Can you also enable force pushes for that case?

duongdev commented 9 months ago

@jhhayashi I have disabled "Require a pull request before merging" and enabled "Allow force pushes" to your github username. Could you try again?

jhhayashi commented 8 months ago

Force pushing to main still fails with a couple errors:

remote: error: GH006: Protected branch update failed for refs/heads/main.                                                                                                                                   
remote: error: Required status check "run" is expected.

But I am able to create PRs and merge them. The downside is that release-it will not be able to manage the tagging/releasing because the commit hash changes when merging the PR (and the tag that release-it creates will be pointing to the wrong commit). The workaround is for me to create the tag/release manually, and maybe eventually have this happen in a Github Action