Closed kingdavidmartins closed 2 years ago
Once approved will run node generator/generate-svg.js
let me know if I should run this command or another command? seems like when I run it prettier is not applied? My guess is the pre commit hook should run but it is not at least for me
Hey @kingdavidmartins, thank you for your contribution. Appreciated.
In order to generate new code, you can run yarn generate
(or npm run generate
). I have added the yarn format
script that helps you to format the generated code. You should merge origin main
to your branch to have that code.
After that, could you please run the mirror icons in the example and put a screenshot here? So I can approve quickly.
By the way, please update the README.md
to help other users know that we had mirror
supported. You can follow the react-phosphor
doc here: https://github.com/phosphor-icons/phosphor-react#props
Thanks!! 🥳
Updated Example and added example usage in README
@duongdev Let me know if there is anything else I need to do for this to get a ✅
@kingdavidmartins It seems you didn't run prettier for the generated tsx files or the formatter didn't work properly. Please try formatting the generated code.
@duongdev updated. Prettified 😇
@duongdev I also added 32b274f since this was the reason why the diff was not showing, per prettier docs the --write
flag to format a file in-place
@duongdev bumping
354ffb312cb4af0a73c118f57d08c08456c9f9c0 - contains the changes for mirrored