search

duongdev / phosphor-react-native

phosphor-icons for react-native. A flexible icon family for React Native
https://www.npmjs.com/package/phosphor-react-native
MIT License
189 stars 25 forks source link

How to bump phosphor-icons version? #9

Closed Joeao closed 2 years ago

Joeao commented 2 years ago

Documentation Request

I'm trying to generate icons from https://github.com/phosphor-icons/phosphor-icons/ v1.4.

When copying phosphor-icons/assets into phosphor-react-native/svgs I notice that each .svg differs. Copying from phosphor-react/assets to phosphor-react-native/svgs also shows a difference in structure. So I'm wondering where are the assets in this repo's svgs directory sourced from? If this is documented in the repository then it should be easier for other users to bring this repo up to date and submit pull requests.

duongdev commented 2 years ago

Hi @Joeao, thank you for noticing that. I've just tried to replace the icons in this repo with the icons from phosphor-icons@1.3.1 https://github.com/phosphor-icons/phosphor-home/releases/tag/v1.3.1 and there are no differences. So if you want to bump to phosphor-icons v1.4 you can replace the SVGs from there to svgs here. It should be no problems.

Joeao commented 2 years ago

Right, I understand. The svg files are from the release rather than the assets directory in the source code.

Thanks for the info, I'll try it now.

duongdev commented 2 years ago

Closed by #11