duosecurity / duo_api_nodejs

Other
20 stars 20 forks source link

Added option to call the api with Promises #29

Closed driverjb closed 4 years ago

driverjb commented 4 years ago

I closed my previous pull request because it had some extraneous changes due to some editor formatting differences. This PR does not have that problem. The following has been added:

This does not touch the existing functionality. In fact it uses it. So these behave exactly the same as the original calls, but with the added convenience of being Promises. These changes will have no effect on those currently using the library (thus the minor version increment instead of major).

driverjb commented 4 years ago

I reviewed the travis CI jobs. It's failing for Node 6, 7, 8 and 9. These Node versions are no longer supported. It passed the Node 10 tests. I developed and unit tested my code on the latest LTS build (Node 12).

You should remove the no longer supported versions especially given that this is a security related software product.

driverjb commented 4 years ago

I am closing this request and will resubmit with the updated travis configuration.