Added the ability to use the library with Promise or Async/Await syntax.

driverjb commented 4 years ago

jsonApiCallAsync: Works just like jsonApiCall but instead of expecting a callback function a Promise object is returned. The promise will resolve when the 'stat' field is 'OK'. It will reject when the 'stat' field is not 'OK'. This makes for better use of Promise patterns like then().catch() and try/catch.
apiCallAsync: Works just like apiCall but returns a Promise following the same pattern as jsonApiCallAsync.

This does not touch the existing functionality. In fact it uses it. So these behave exactly the same as the original calls, but with the added convenience of being Promises. These changes will have no effect on those currently using the library (thus the minor version increment instead of major).

I also updated the travis CI configuration to reflect the currently supported NodeJS versions.

Reference: https://nodejs.org/en/about/releases/

PR (#30) is incorrect since NodeJS version 11 is not currently supported, and it does not include version 14 which is the latest build that will begin LTS on 10.27.2020.

jpegram2 commented 4 years ago

Any updates on when this will be released?

driverjb commented 4 years ago

I haven't heard from the project maintainer. For our production build, I just include their module and then expose the two functions I have provided in this MR as a local module. Annoying, but works.

AaronAtDuo commented 4 years ago

Hi folks, sorry, we forgot to update this. We have some of our Node developers taking a look at this and we hope to act on it within the next week or so!

driverjb commented 4 years ago

@AaronAtDuo Any word?

janderson215 commented 3 years ago

Any update on this?

driverjb commented 3 years ago

@AaronAtDuo It's been a little more than a few weeks. Any updates?

driverjb commented 2 years ago

Any updates? I am considering working on this module again to bring in Typescript definitions because our team is in the process of upgrading our API with type support. Is this module still being monitored or should I start my own?

driverjb commented 2 years ago

I have created my own module for anyone interested: https://www.npmjs.com/package/duo-admin-api.

duosecurity / duo_api_nodejs

Added the ability to use the library with Promise or Async/Await syntax. #31