duosecurity / duo_client_python

Python library for interacting with the Duo Auth, Admin, and Accounts APIs
https://duo.com/docs/
Other
136 stars 135 forks source link

Automatic proxy configuration #222

Open ramonpetgrave64 opened 1 year ago

ramonpetgrave64 commented 1 year ago

Hello from lyft/cartography!

We're using the duo client and realized that it doens't automatically use the HTTP_PROXY environment variable. We've been using your provided method set_proxy, but it would be nice to have this be automatic, like the examples below.

AaronAtDuo commented 1 year ago

@ramonpetgrave64 Thanks for the suggestion. We'll consider it, but it would have to wait for a major version release since I think this would count as a backwards-incompatible change.

ramonpetgrave64 commented 1 year ago

@AaronAtDuo Thanks for the reply. Alright. In the mean time, you could introduce an optional switch, like use_proxy_env_variable.