Fixing contextPath and making it not look lame ;)

zfasel commented 9 years ago

1) Attempted to integrate the compiled jar to a confluence install that was in a non-root context path (i.e. /wiki). Duo didn't play nice. Made duo play nice with others by implementing context path. This was mostly adopted from https://github.com/duosecurity/duo_jira/commit/95199e92da96fc89d04d580e7caa9bd878f3d958 as this was an issue on that side as well already previously fixed.

2) Duo looked sad. Duo shouldn't look sad. Made Duo page follow implemented theme template using the decorator meta.

3) Updated dependency versions as I was having compile issues, but turns out it was related to JAF missing. shrug - Related compile fix is at https://developer.atlassian.com/docs/faq/atlassian-plugin-sdk-faq/maven-cannot-find-java-mail-java-activation-or-jta, so feel free to toss out the update to the library versions.

Random Notes:

Tested on Confluence 5.7
Didn't update version number in pom.xml nor include a compiled jar, but can. Not sure your numbering scheme and didnt want to assume 1.3.1.

BradleyHiggins commented 9 years ago

Thanks for reporting this issue. We'll dig into it!

Thanks for using Duo

Sharkking commented 9 years ago

contextPath Issue confirmed with confluence 5.6.6.

erikbarbara commented 9 years ago

Thanks for this pull request. I have pushed a fix with your changes to address #1 in your above comment. We didn't pull in the UI changes or pom.xml incrementation. We try to keep the duologin.vm bare bones and allow users to perform custom changes as described in our docs: https://www.duosecurity.com/docs/jira#appendix-building-manually

Thanks again for using Duo!

duosecurity / duo_confluence

Fixing contextPath and making it not look lame ;) #4