Support for duologsync.log Rotation & Max File Size

duosecurity / duo_log_sync

MIT License

37 stars 28 forks source link

Open jjfallete opened 2 years ago

jjfallete commented 2 years ago

RotatingFileHandler is necessary to prevent the duologsync.log file from increasing in size indefinitely until the disk fills.

This allows for 3 rotations of the log file (4 total), each capping at 25MB.

We tested this and it appears to be working, but I recommend additional testing or adjusting of the added code as desired.

Coldfirex commented 11 months ago

Is this needed so we dont have to manually clear out the log file ever so often? It just grows in size.

jjfallete commented 11 months ago

@Coldfirex -- exactly. I'm not sure why Duo hasn't responded to this Pull Request. @MarkTripod-Duo maybe you can review?

It could be revised to be configurable within the ini as well, this was just a quick and dirty solution we've applied in our env.