search

dupondje / PHP-Push-2

Z-Push Fork With CalDAV/LDAP Support
GNU Affero General Public License v3.0
67 stars 24 forks source link

SYNC_FOLDER_TYPE_XXX VS SYNC_FOLDER_TYPE_USER_XXX #2

Closed xbgmsharp closed 12 years ago

xbgmsharp commented 12 years ago

In GetFolder I add additional Folder type. I am not about the difference but according to the name it does make sense. What do you think?

dupondje commented 12 years ago

Comitted a bit different. In you config you define('CALDAV_PERSONAL', 'personal'); and then it will do what you want :)

But this way the personal can be some other folder OR nothing.

Tx

Op 17-04-12 16:18, xbgmsharp schreef:

In GetFolder I add additional Folder type. I am not about the difference but according to the name it does make sense. What do you think?

  • $folder->type = SYNC_FOLDER_TYPE_APPOINTMENT;
  • if (substr($id, 1) == "personal")
  • $folder->type = SYNC_FOLDER_TYPE_APPOINTMENT;
  • else
  • $folder->type = SYNC_FOLDER_TYPE_USER_APPOINTMENT; } else {
  • $folder->type = SYNC_FOLDER_TYPE_TASK;
  • if (substr($id, 1) == "personal")
  • $folder->type = SYNC_FOLDER_TYPE_TASK;
  • else
  • $folder->type = SYNC_FOLDER_TYPE_USER_TASK;

Reply to this email directly or view it on GitHub: https://github.com/dupondje/PHP-Push-2/issues/2

xbgmsharp commented 12 years ago

Sound nice. Do you know the difference between those 2? Does it make sense to use them?