dupondje / PHP-Push-2

Z-Push Fork With CalDAV/LDAP Support
GNU Affero General Public License v3.0
67 stars 24 forks source link

Included CALDAV_PORT in argument passed to CalDAVClient constructor #52

Closed MikeEvans closed 11 years ago

MikeEvans commented 11 years ago

I set a non-standard port for SSL on my CalDAV server, but the value I set in config.php file was not being passed through.

MikeEvans commented 11 years ago

Sorry, I don't understand. It looks to me like you added the CALDAV_PORT setting to the config file yourself back in June, but it's not being used anywhere - https://github.com/dupondje/PHP-Push-2/commit/33615d6f2eb6bc5ba5661380da36316e81e1dd82#config.php

If you don't think the port parameter is necessary, I suggest you remove it entirely, as it is a source of confusion.

dupondje commented 11 years ago

Didn't know what I added in June ... :) Fixed now. Thx