duraspace / pcdm

Portland Common Data Model
http://pcdm.org/models
Apache License 2.0
90 stars 11 forks source link

Adding pcdm:Order class #32

Closed escowles closed 8 years ago

escowles commented 8 years ago

See https://docs.google.com/document/d/1x2ySLd6Oag_gsejXBPWV5AL2SFzS1swwCUk9N9isJVM/edit# (Multiple Orders section)

azaroth42 commented 8 years ago

:+1:

ruebot commented 8 years ago

:+1:

scossu commented 8 years ago

:+1:

ruebot commented 8 years ago

That's 3 binding :smile:

Shall we wait for more commentary, or is that it?

awoods commented 8 years ago

See: https://github.com/duraspace/pcdm/pull/31#issuecomment-143043727

jpstroop commented 8 years ago

Why:

Only for second and subsequent orders.

Isn't that going to get confusing? I have no doubt that the multiple orders use case will surface, but at that point it seems a little awkward to me that the different orders available would be related to the object in different ways. Is one order favored over the other? If so, that should be made clear. Maybe there's another reason for this that I'm missing? Otherwise the semantics seem less clear than they could be to me.

jpstroop commented 8 years ago

Ah. The rdfs:comment clears it up a bit. Maybe the name of the class should be pcdm:AlternateOrder?

escowles commented 8 years ago

The main reasoning for only using pcdm:Order for second and further orders is simplicity for single-order objects. So calling it pcdm:AlternateOrder sounds good to me.

escowles commented 8 years ago

I've renamed the class to AlternateOrder and cleaned up the description.

ruebot commented 8 years ago

:+1:

ruebot commented 8 years ago

Oh, I think we have merge conflicts now that #31 went in.

escowles commented 8 years ago

@ruebot: I've rebased and now it'll merge cleanly!

ruebot commented 8 years ago

@escowles++

ruebot commented 8 years ago

Now to sort out whether or not we have three thumbs on AlternateOrder :smile:

@jpstroop @scossu @azaroth42 @awoods

awoods commented 8 years ago

:+1: ...just need one more.

azaroth42 commented 8 years ago

:+1: to pcdm:AlternateOrder