duraspace / pcdm

Portland Common Data Model
http://pcdm.org/models
Apache License 2.0
90 stars 11 forks source link

Adding optional sidecar FileSet class and related predicates #69

Closed escowles closed 3 years ago

escowles commented 8 years ago

Objects always link directly to Files, but can also link to FileSets that link to Files:

See also #68

ruebot commented 8 years ago

Do we need to also update the domain and range of hasFile and isFileOf? https://github.com/duraspace/pcdm/blob/d7464e541484f68f2213ab6e676de837bc44fd71/models.rdf#L69-L86

whikloj commented 8 years ago

@ruebot I don't think so, they should (and do) refer to the relationship between a pcdm:Object and a pcdm:File

ruebot commented 8 years ago

@whikloj ah, yeah, you're right.

See also "sidecar".

facepalm

azaroth42 commented 8 years ago

:meh: Just makes life difficult for interoperability. I don't see the point compared to an Object that takes this role if it's not required.

escowles commented 8 years ago

@azaroth42 I think the advantage to this approach is that it can be completely ignored if your application doesn't care about FileSets. @tpendtragon also suggested the possibility of omitting the FileSet completely and linking between Files to establish the derivation chain, which you could use to figure out the groupings as-needed.

cmharlow commented 8 years ago

FWIW, not being a voting member or anything, my thoughts on this and #68. Looking at PRs (+ needs re:optional FS) on the table, I prefer this one, with the following points:

On that last point, I'd like these questions answered or discussed really soon if this goes through, albeit I fully understand many are implementation-specific:

pcdm:Object pcdm:hasFileSet pcdm:FileSet pcdm:managesFile pcdm:File

depending on the implementation, has this shortcut or mapping:

pcdm:Object pcdm:hasFile pcdm:File

My notes on both PRs where I worked through examples and thoughts, in case of interest: https://gist.github.com/cmh2166/5e435300a246e3406d9ff0db04cecde2

cmharlow commented 8 years ago

Sorry to have stalled the communication. Ignore my comments / questions as needed!

escowles commented 8 years ago

My thoughts on @cmh2166 's questions:

escowles commented 3 years ago

Closing this old PR since there was never consensus on these issues.