durch / rust-s3

Rust library for interfacing with S3 API compatible services
MIT License
519 stars 198 forks source link

`make ci` failing due to `Credentials::default` implementation #327

Closed joaommartins closed 1 year ago

joaommartins commented 1 year ago

Describe the bug make ci fails on master branch due to clippy error on Credentials::default implementation.

To Reproduce make ci

Expected behavior make ci passes without skipping clippy check, by implementing the std::default::Default trait instead of a member function as it is currently.

Environment

Additional context This is a simple issue to fix, but the std::default::Default trait default() return is different to the current Credentials::default. Changing the return type creates the need to update all the usage of Credentials::default, as well as all the documentation and examples.

durch commented 1 year ago

@joaommartins thanks for raising, fixed