search

durch / rust-s3

Rust library for interfacing with S3 API compatible services
MIT License
519 stars 198 forks source link

Minor compilation fixes #331

Closed mina86 closed 1 year ago

mina86 commented 1 year ago

Firstly, observe that aws-creds doesn’t compile without default features enabled. This is because Credentials::refresh method which calls Credentials::default which is only defined if http-credentials feature is enabled. Change the code (and related tests) so that the former method is present only if that feature is enabled.

Note that even with that, rust-s3 doesn’t compile without default features enabled. This is because rust-s3 depends on aws-creds with the above bug present. This will be fixed once the dependency is updated.

Secondly, fix minor compilation warnings caused by conditional compilation leading to some dead code.

durch commented 1 year ago

@mina86, thanks for raising, fixed in 0.33