#299 introduces a regression that breaks rustls + tokio support

durch / rust-s3

Rust library for interfacing with S3 API compatible services

MIT License

498 stars 195 forks source link

#299 introduces a regression that breaks rustls + tokio support #336

Open ryanswrt opened 1 year ago

ryanswrt commented 1 year ago

Describe the bug Previously the with-tokio feature could be used with tokio-rustls-tls - allowing for easy static compilation with musl. After #299 was merged, with-tokio will always pull in native-tls; which forces an openssl dependency

To Reproduce Upgrade from 0.33.0 to 0.34.0-beta2 with only the with-tokio and tokio-rusttls-tls features enabled, and you will no longer be able to compile with musl

Expected behavior rusttls to be used

durch commented 1 year ago

@ryanswrt, good callout, we've remove reqwest, and there is some fallout, it will be cleaned up before the next beta

lpotthast commented 10 months ago

Ran into the same issue. This is still an issue with the latest beta3 release.