search

durch / rust-s3

Rust library for interfacing with S3 API compatible services
MIT License
498 stars 195 forks source link

draft: use async await & async sync rwlock for credentials in bucket #343

Closed a-nickol closed 8 months ago

a-nickol commented 1 year ago

fixes #337

but i am not quite sure about the architecture of the library, since the fix uses a tokio and async std struct for synchronization, this PR is not usable for usage with feature sync-native-tls.

FHTMitchell commented 1 year ago

Hi we just ran into this problem, would like to see this reviewed and merged...

a-nickol commented 1 year ago

The implementation is still a draft I would say, nevertheless it works for me. I think the implementation must work with each combination of feature flags for this crate, which for sure, does not work.

durch commented 8 months ago

This is a good idea, implemented in 729791a30b63ae72890d43d4e4ed4f6ca6a28e4b