remove check for is_ec2 when finding credentials (fixes #362)

durch / rust-s3

Rust library for interfacing with S3 API compatible services

MIT License

498 stars 195 forks source link

remove check for is_ec2 when finding credentials (fixes #362) #363

Closed droundy closed 8 months ago

droundy commented 8 months ago

I just removed the is_ec2 and changed the first error to return NotEc2, so we would return a nice error in cases where the endpoint is not present at all.

durch commented 8 months ago

@droundy not sure about the change, the send can likely fail for a number of reasons, and always mapping it to EC2 seems worse then what is currently there

durch commented 8 months ago

Closing for now