durch / rust-s3

Rust library for interfacing with S3 API compatible services
MIT License
498 stars 195 forks source link

feat: re-expose 'http-credentials' from 's3' #364

Closed woshilapin closed 8 months ago

woshilapin commented 8 months ago

aws-creds is re-exposed from s3. This means, technically, we don't need to depend on aws-creds when we already depend on s3. However, if we need the http-credentials from aws-creds, then we do need to depend on both which can create problems:

That's usually the reason for re-exposing aws-creds from s3 (to avoid this different versions of the same crate in the dependency tree). But today, there is no way to have http-credentials without importing both. This PR should solve that.

durch commented 8 months ago

@woshilapin, good call, merged, published in 0.34.0-rc4