search

durch / rust-s3

Rust library for interfacing with S3 API compatible services
MIT License
499 stars 195 forks source link

Some feature combinations no longer compile #395

Open nyurik opened 5 days ago

nyurik commented 5 days ago

Describe the bug

This worked ok in v0.33.0, but fails in v0.34.0.

cargo check --no-default-features --features tokio-native-tls

To Reproduce

git checkout v0.33.0
# works fine
cargo check --no-default-features --features tokio-native-tls
git checkout v0.34.0
# no longer compiles
cargo check --no-default-features --features tokio-native-tls

Expected behavior All combinations of non-default features should be compilable, and preferably without any warnings

Environment

lseelenbinder commented 5 days ago

A git bisect indicates this is the first bad commit: https://github.com/durch/rust-s3/commit/0ff4d612902519b7529d06ab564f75e9b222a70f

nyurik commented 5 days ago

I tried to figure out where to add a few more cargo check --no-default-features --features ... commands to the makefile, but got a bit lost there. BTW, I have been using just instead of make -- tends to be a bit cleaner, and now there are IDE and CI actions for that (but that's obviously not the blocker here :) )

emmiegit commented 3 days ago

Since this also involves Tokio and a TLS setting, I wonder if there is any relation to #396.