search

durch / rust-s3

Rust library for interfacing with S3 API compatible services
MIT License
527 stars 202 forks source link

Please reconsider printing out BTC donation banner #401

Closed functorism closed 2 months ago

functorism commented 2 months ago

I really think you should reconsider printing out the BTC donation banner.

durch commented 2 months ago

@functorism I like that a reaction is already coming in, could you please elaborate on what the objection is exactly? There is a feature to disable the banner disable-call-for-funding.

My intention here was not to be spammy, but highlight that some support will go a long way. Open source projects are pretty hard to fund. I'd like to spend more of my time working on rust-s3, but bills do need to be paid, so there is always a tradeoff...

functorism commented 2 months ago

I think you're more than justified to have the donation call out in the README, of course

That it gets printed out downstream for users who use this library is however indeed spammy, in my opinion. For example the banner got flashed to me when I ran my tests, so I had to scroll past the rather large donation banner to view my test output.

I just don't have an expectation that functional libraries I install will pollute my stdout/stderr with information not pertaining to execution.

It's a good call to have a feature flag to disable. And maybe that's enough.

durch commented 2 months ago

Thats a fair point, experiment concluded, thanks for the engagement :)