Closed GoogleCodeExporter closed 8 years ago
line 64: ieQuirks = $.browser.msie && !$.boxModel, .boxModel is depreciated in
jquery-1.3, and it returns undefined (if i remember correctly) !undefined =
true, so
this evaluates to true && true = ieQuirks.
The new method is $.support.boxModel, but it requires the document.ready,
otherwise
it will return null. I wasn't sure how to modify it to work appropriately.
As a quick hack, I changed the line to ieQuirks = false, So it'll still hit if
it's
ie6, but not 7 in quirks mode unfortunately.
hope this helps, great plugin.
~Geo
Original comment by geobmx...@gmail.com
on 28 Feb 2009 at 9:56
This should be fixed in 1.2.3 - let me know if you still have issues.
Original comment by emartin24
on 2 Mar 2009 at 5:42
Hi Eric,
I'm testing with the released version of IE8, jquery-1.3.2.min.js and
jquery.simplemodal-1.2.3.js
I'm receiving the error noted here:
http://www.ericmmartin.com/projects/simplemodal/#comment-6175
on the line:
s.removeExpression('height');
My best to you and yours,
Jeffrey
Original comment by jeffrey....@gmail.com
on 7 Apr 2009 at 10:46
Jeffrey,
Do you get the error on either of the following pages:
http://www.ericmmartin.com/simplemodal-test/
http://www.ericmmartin.com/simplemodal/
If not, can you point me to a place where it does happen? Do you have any
settings
changed in IE8?
I had another user report that this was an issue with SimpleModal 1.2.2, but
that it
was resolved in 1.2.3.
Original comment by emartin24
on 8 Apr 2009 at 1:25
[deleted comment]
I'm getting the exact same issue at the same location - following site
yardstogardens.org/dev
the code is in the main.js file function that calls it is below
function showEditListingModal(inMode, inListing) {
var tpE = {"listingModal_header":"Create a new Listing", "saveButtonText":"Submit",
"id":-1};
editListing.sendMode = "new";
if(typeof(inMode) == "string" && inMode == "edit") {
tpE.listingModal_header = "Edit your Listing";
tpE.saveButtonText = "Save Changes";
tpE.id = inListing.id;
tpE.s_confirm = inListing.s_confirm;
editListing.sendMode = "edit";
}
$.modal.close();
$.modal($.snippet("edit_listing", tpE), editListingConfig);
$("#listing__zip").listen(
{ 27:function(e, listener) { $("#listing__zip").val("");},
"regEx":/^[0-9]{0,5}-?([0-9]){0,4}$/,
"invalidAction":"swallowKey"
}
);
}
Original comment by donovan....@gmail.com
on 15 May 2009 at 8:34
I found a workaround.
I got the exact same error as described above. 'Not implemented' error in IE8.
The
debugger stops at the line:
s.removeExpression('height');
In Firefox it works fine.
I downloaded the 3 jquery javascript files from the demo page :
http://www.ericmmartin.com/simplemodal-test/
(jquery.js, simplemodal.js and simplemodal.jquery.js)
When I used these 3 files the error was gone. It now works in IE7, IE8, Firefox
The previous (non working) files are attached in a zip file.
(jquery-1.3.2.min.js
and jquery.simplemodal.js)
Hope this helps,
W0ut
Original comment by wouter.l...@gmail.com
on 23 Jun 2009 at 8:41
Attachments:
I too receive this problem in IE8, but not if compatibility mode is turned on.
I am
using version 1.3.
Original comment by maf...@gmail.com
on 1 Sep 2009 at 11:26
I'm having the same problem here.
'Not Implemented' error in IE8 on "s.removeExpression('height');" line.
Does anybody knows how to fix this?
Original comment by gustavob...@gmail.com
on 16 Sep 2009 at 3:24
gustavobello comment 7 explains how to fix it.
Original comment by donovan....@gmail.com
on 16 Sep 2009 at 3:44
gustavobello - what version of jQuery and SimpleModal are you using?
Original comment by emartin24
on 18 Sep 2009 at 1:04
Same problem here.
I think it has nothing to do with the version of jquery or SimpleModal..
In IE8 standards mode support for expressions has been removed:
http://blogs.msdn.com/ie/archive/2008/10/16/ending-expressions.aspx. The check
for
G.style.removeExpression returns true, but the call to the method throws a "Not
Implemented" error.
This may be a bug in IE8, but it's unlikely to be fixed before it is released,
and
I've been unable to submit a bug at the
https://connect.microsoft.com/IE/Feedback
site. Therefore it may be necessary to work around it.
... please let me know if there has been progress on this (expl. workaround ?)
Original comment by gerritja...@gmail.com
on 30 Oct 2009 at 11:03
I made changes to the script with the document ready code and it works great
now.
heres the code
$(document).ready(function() {
$("#sample").modal({
minHeight:200,
minWidth: 450,
onClose: function (dialog) {
dialog.data.fadeOut('slow', function () {
dialog.container.hide('slow', function () {
dialog.overlay.slideUp('slow', function () {
$.modal.close();
});
});
});
}});
});
Thanks for the hint from the 1st commentor, cheers!
Original comment by luvlyr...@gmail.com
on 1 Nov 2009 at 8:38
Hi All,
Just to let you know that I am still encountering this issue.
I have downloaded the latest version of SimpleModal
(4_jquery.simplemodal-1.3.3.js),
and this did not solve the issue.
I am using jQuery version 1.3.2.
Any feedback is greatly appreciated.
Original comment by giammarc...@gtempaccount.com
on 12 Jan 2010 at 10:50
I'm getting the "Not Implemented" error when I run the vsdoc (Visual Studio
documentation) version of jquery. The straight minified version works fine.
Original comment by add...@gmail.com
on 9 Feb 2010 at 3:57
I had the same problem. As I fetched the jquery and simplemodal scripts before
the portion of code which included the call to the modal function, I've thought
it wouldn't be necessary to wrap it int a "document.ready" code. But it was!
So, the solution was having
$(document).ready(function() {
$("#mydiv").modal();
});
Original comment by tyrons
on 14 Jun 2010 at 1:12
Still a problem in 1.3.5 with jQuery 1.4.2. Issue identified in comment #1.
Solution there was to set ieQuirks = false, however, that may break in earlier
versions of IE.
Suggest change from:
ieQuirks = $.browser.msie && !$.boxModel;
To:
ieQuirks = jQuery.support.boxModel;
Tested in IE8 Standards mode, IE7 compatibility mode, Firefox 3.6.6, Opera
10.51, Google Chrome 5.0.375.99
Original comment by jlc...@gmail.com
on 18 Jul 2010 at 1:56
I can't recreate the issue. Can you provide a scenario in which you get this
issue? Also, make sure you aren't calling modal() until the DOM is ready.
Original comment by emartin24
on 20 Jul 2010 at 11:13
You hit on my mistake. I was calling modal(), but wasn't waiting until the DOM
was ready. If I had read down to comment 16 before I found my other solution, I
probably would have tried that. Thanks.
Original comment by jlc...@gmail.com
on 26 Jul 2010 at 2:23
i tried the comment 17 solution and it worked for me....
ieQuirks=$.browser.msie&&!$.support.boxModel
to
ieQuirks = jQuery.support.boxModel;
Original comment by prashant...@gmail.com
on 10 Sep 2010 at 9:40
I had these problems on IE8/compatability mode OFF, and only when dealing with
a very slow web server. In this scenario, I could just watch IE downloading
the images ("25 images remaining...").
For me, changing $(document).ready to ${window).load did the trick.
Original comment by adamrab...@gmail.com
on 15 Sep 2010 at 7:55
This is still an issue in 1.4.1
in:
IE8.0.7600.16385 in normal
(with Compatibility mode ON it works fine)
with:
jquery 1.4.4
Original comment by ole.kall...@gmail.com
on 20 Jan 2011 at 3:27
i don't know if this is related, but i have some major width issues with 1.4.1
and ie 9 quirks mode (not compatibility mode), it breaks - the container width
is always 100%. i've tried with jquery 1.4.2 and 1.6.1 - same issue. however,
version 1.3 of simplemodal works fine with either jquery version (in ie9 quirks
mode) whereas 1.4.1 breaks.
Original comment by fowler....@gmail.com
on 20 May 2011 at 2:42
I am having the same issue.I am using:
- jquery.simplemodal-1.4.1.js
- jquery-1.6.1.min.js
I am not calling modal() until the user selects a state from a dropdown list.
So the DOM is completely loaded by then.
I pulled the page off our production server and put it on my personal site so
others could look at the issue.
http://meysenburg.com/MDU/index.html
Original comment by eric.mey...@gmail.com
on 20 May 2011 at 7:03
It looks like it is also solved for IE8 with the new 1.4.1 version.
Altough the changelog only mentions "Resolved the container height issue in IE6
& IE7 with jQuery 1.4.3"
Anybody else where it is solved with 1.4.1 version? (I'm using jQuery 1.6.1 +
SimpleModal 1.4.1)
Original comment by AniMatri...@gmail.com
on 13 Jul 2011 at 1:19
[deleted comment]
I'm seeing this issue using jquery.simplemodal-1.4.1.js and jQuery 1.6.1 using
iframes in IE8 (actually IE9 emulating IE9). In stepping through the jQuery, I
see that in my main frame support.boxModel is set to true and in the iframes
it's (incorrectly) set to false. It seems like support.boxModel is cannot be
relied on and simplemodal needs to find a better way to do this test.
I worked around it by setting my iframe's src in my main frame's
$(document).ready().
Original comment by mhenry1...@gmail.com
on 7 Sep 2011 at 9:27
how to access textbox value on server side which is in simplemodal
Original comment by javedsm2...@gmail.com
on 7 Feb 2012 at 11:33
forms control used in simplemodal not accessed on server side, please solve
this issue asap
thank in advance
Original comment by javedsm2...@gmail.com
on 7 Feb 2012 at 11:48
how to access textbox value on server side which is in simplemodal.
forms control used in simplemodal not accessed on server side
Original comment by javedsm2...@gmail.com
on 15 Feb 2012 at 11:29
javedsm2, your question has nothing to do with this issue, which is "IE8 +
jQuery 1.3 + SimpleModal 1.2.2 Bug". It sounds like your question has nothing
to do with simplemodal at all, and you need to get a better understanding of
the basics of web development. The simplemodal issue tracker is not an
appropriate place for that. I would recommend reading some books on the
subject.
Original comment by mhenry1...@gmail.com
on 15 Feb 2012 at 2:34
mhenry1, may be this question is not regarding to this bug but normally when i
use another popup control then on server side i directly access value of
textbox but in simpalmodal it always give me blank value.if you have any
solution on this please give me.
Original comment by javedsm2...@gmail.com
on 7 Apr 2012 at 6:27
jquery 1.8.0 and simplemodal 1.4.2 IE9
im getting error Object doestn support property or method 'removeExpression'
it works fine in chrome
Original comment by aris.ba...@gmail.com
on 21 Aug 2012 at 9:41
[deleted comment]
jquery 1.8 and simplemodel 1.4.2 on IE8
I am experiencing this same issue.
As the original comment mentions, this seems to be due to ieQuirks being true.
When I change the line defining ieQuirks to be
ieQuirks = $.browser.msie && !$.support.boxModel
the problem goes away.
Original comment by petersum...@gmail.com
on 27 Aug 2012 at 5:37
I can confirm that the fix mentioned earlier,
ieQuirks = $.browser.msie && !$.support.boxModel
does indeed fix the problem.
Confirmed working with IE8, IE9, FF and Chrome.
Original comment by kok...@gmail.com
on 30 Aug 2012 at 2:59
+1 Thank you for the help from everyone. If you are using
jquery.simplemodal.1.4.2.min.js as I am, then you'll need to search for the
line below (row 10 col 202 for me):
m=b.browser.msie&&!b.boxModel;
--> change to -->
m=b.browser.msie&&!b.support.boxModel;
Not a big jump to figure that out but thought I'd share.
Original comment by Katrina....@gmail.com
on 17 Sep 2012 at 5:58
i had a similar issue but wasn't fixed by the above - however the fix at
https://code.google.com/p/simplemodal/issues/detail?id=88 worked for me -
commenting out the contents of the fixIE function.
Original comment by samudrad...@gmail.com
on 13 Dec 2013 at 2:00
better again,
ieQuirks = browser.msie && !$.support.boxModel
work fine without using jquery removed $.browser ;)
Original comment by omat...@makazi.com
on 18 Dec 2013 at 3:06
Original issue reported on code.google.com by
emartin24
on 27 Jan 2009 at 9:23