durgaprassad7 / simplemodal

Automatically exported from code.google.com/p/simplemodal
0 stars 0 forks source link

SM stops working IE9 when upgrade to jQuery 1.8.0 #86

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
SimpleModal or SimpleModal Contact Form (SMCF)?

SM

Version of SimpleModal of SMCF (indicate Demo or WordPress plugin)?

1.4.1

Version of jQuery?

1.8.0

Browser/OS you are experiencing the problem with?

IE9 Win

If applicable, please provide a code snippet or link to a website
demonstrating the problem.

  $('#chemBrowser').click(function (e) {
    return selectionModal(e, $(this).attr("href") + '&browser=s', ctdConfig.objectTypeCodes.chemical);
  });

function selectionModal(e, src, targetFieldId) {
  // If field value exists, feed it to a keyword query.
  // Assumes the URL already has at least one param.
  var fieldVal = $('#' + targetFieldId).val();
  if (fieldVal != "") {
    src = [src, '&queryTerms=', fieldVal].join('');
  }

  // Set targetField attribute in query form with current field ID
  // to be used by the modal window to populate that field via sendVocValue().
  var targetField = $("#targetField");
  if (targetField.length < 1) {
    $('<input/>')
        .attr("type", "hidden")
        .attr("id", "targetField")
        .attr("name", "targetField")
        .appendTo("#queryform");
    targetField = $("#targetField");
  }
  targetField.val(targetFieldId);

  // Open the modal.
  e.preventDefault();
  $.modal('<iframe src="' + src + '" height="550" width="575" style="border:0">', {
    closeHTML:"<a href='#' title='Close' class='modal-close'>x</a>",
    containerCss:{
      height:550,
      width:575
    },
    onOpen:function (dialog) {
      dialog.overlay.fadeIn('normal', function () {
        dialog.container.slideDown('fast', function () {
          dialog.data.fadeIn('fast');
        });
      });
    },
    opacity:30,
    position:['0']
  });
  return false;
}

If applicable, please list the other code/libraries/plugins you are trying
to integrate with.

Original issue reported on code.google.com by michae...@gmail.com on 20 Aug 2012 at 6:50

GoogleCodeExporter commented 8 years ago
The IE9 debugger complains about the following SimpleModal line:

g.removeExpression("height");

SCRIPT438: Object doesn't support property or method 'removeExpression' 
global.v11558.js, line 128 character 440

Original comment by michae...@gmail.com on 20 Aug 2012 at 6:54

GoogleCodeExporter commented 8 years ago
SimpleModal works if IE's 'Compatibility View' is turned on for the page, but 
not otherwise.

Original comment by michae...@gmail.com on 20 Aug 2012 at 6:59

GoogleCodeExporter commented 8 years ago
No joy with SimpleModal 1.4.2, either. :(

Original comment by michae...@gmail.com on 20 Aug 2012 at 7:06

GoogleCodeExporter commented 8 years ago
Same as issue 87

Original comment by michae...@gmail.com on 21 Aug 2012 at 6:08

GoogleCodeExporter commented 8 years ago
Thanks. This should be fixed now with SimpleModal 1.4.3.

Original comment by emartin24 on 8 Sep 2012 at 4:07

GoogleCodeExporter commented 8 years ago
Still getting the same issue with even 1.4.3

Original comment by nageswar...@gmail.com on 10 Apr 2013 at 9:47