durhamatletico / durhamatletico-cms

A Drupal 8 site for Durham Atletico
https://www.durhamatletico.com
2 stars 3 forks source link

Theme updates #199

Closed AnneTee closed 6 years ago

AnneTee commented 6 years ago

It's happening! πŸ‘ Here's a giant PR for your review at your convenience!

Summary

I overhauled pretty much the entire theme! Some details:

Information you need

To test

Note that I'm still planning on doing some cross-browser and accessibility testing.

Featured Item

Posts

Submenus

Unfortunately I couldn't fix the issue with submenus only showing on their parent link's page. The "Show as expanded" checkbox isn't being exported to configuration for some reason. You could update the 3 menu items with submenus here as a manual deployment step. This wouldn't be a huge pain if you're not deploying very often.

Questions

Screenshot

screencapture-local-durhamatletico-2018-08-21-20_02_50

AnneTee commented 6 years ago

@kostajh Here are my notes, hope this helps!

kostajh commented 6 years ago

Thanks so much for this!! πŸ₯‡ And for the notes! It looks like CI is failing because the image_style_quality module is missing, could you please add the version you are using via composer require drupal/image_style_quality:VERSION

AnneTee commented 6 years ago

@kostajh I added the module the composer.json but the same error is cropping up when the CI builds, any idea what's going on?