Closed AnneTee closed 6 years ago
@kostajh Here are my notes, hope this helps!
Thanks so much for this!! π₯ And for the notes! It looks like CI is failing because the image_style_quality
module is missing, could you please add the version you are using via composer require drupal/image_style_quality:VERSION
@kostajh I added the module the composer.json
but the same error is cropping up when the CI builds, any idea what's going on?
It's happening! π Here's a giant PR for your review at your convenience!
Summary
I overhauled pretty much the entire theme! Some details:
Information you need
To test
cex
,updb
, andcr
web/themes/custom/atletico/images/default-banner-image.jpg
as the default image. The home page layout will be wonky until you do this.Note that I'm still planning on doing some cross-browser and accessibility testing.
Featured Item
Posts
<h2>
elements have a special style in articles (similar to the page title underline style) which breaks up the text nicelySubmenus
Unfortunately I couldn't fix the issue with submenus only showing on their parent link's page. The "Show as expanded" checkbox isn't being exported to configuration for some reason. You could update the 3 menu items with submenus here as a manual deployment step. This wouldn't be a huge pain if you're not deploying very often.
Questions
Screenshot