search

duritong / puppet-trocla

puppet integration for trocla
11 stars 18 forks source link

fix argument order in trocla_set #28

Closed anarcat closed 4 years ago

anarcat commented 4 years ago

The code (and its inline documentation) does explicitely state the password is the second argument, and not format. I assume this is just a typo.

anarcat commented 4 years ago

i had to dig in the type source code to figure out how this actually worked... it seems there's a disconnect between the (good) inline documentation of the types and the (very limited, and incorrect until this patch) documentation in the README... maybe there is a better way to deal with those disparities?

also: tests fail here, but i doubt they are because of this specific patch, it looks like the test suite has bit-rotten somehow...

duritong commented 4 years ago

Thank you!