duritong / puppet-trocla

puppet integration for trocla
11 stars 18 forks source link

Add Puppet8x support #32

Open flepoutre opened 6 months ago

duritong commented 5 months ago

Thank you, much appreciated!

The collector statement is imho still necessary and it is still supported: https://www.puppet.com/docs/puppet/8/lang_collectors.html

And other than that it would be greate to at least split the indentation changes into their own commit, since this makes it not so clear what are required changes for puppet 8 and what is (debatable) cosmetic changes. Any chance to get that at least splitted?

flepoutre commented 5 months ago

The changes for Puppet8 mainly concern variable typing and legacy facts.