search

duritong / ruby-cobbler

A ruby interface for interacting with a Cobbler server.
GNU Lesser General Public License v2.1
7 stars 5 forks source link

Implement timeout parameter and add specs #8

Closed jonlives closed 9 years ago

jonlives commented 9 years ago

This Pull request adds support to the cobbler gem for the timeout parameter supported by the underlying XMLRPC::Client library it uses. The timeout will still default to 30 seconds as it did before if not specified, but for those cases where the 30 second timeout is not sufficient, this allows it to be increased.

duritong commented 9 years ago

Thanks a lot for your contribution. Can you fix the tests?

jonlives commented 9 years ago

Whoops, will do!

jonlives commented 9 years ago

@duritong I've fixed the failing tests - the remaining fail is 1.8.7 and looks to be related to gem installs - I don't think this is related to my change.

duritong commented 9 years ago

Thanks, I think I fixed the issue.