expire option is presented inconsistently on readme

[Clebam]

Hi,

the option is shown as expires with an s on the readme but is used as expire without an s inside the code.

It seems to work fine with vault 'store' without an s.

[duritong]

The code uses expires all over, so it's definitely correct in the README.

Are you getting an error when using it with an s?

[Clebam]

Hi @duritong , I faced the problem with this part of the code : https://github.com/duritong/trocla/blob/main/lib/trocla/stores/vault.rb#L74

# Works
$trocla_options = {
        'expire' => $trocla_key_expires,
      }

# Did not work
$trocla_options = {
        'expires' => $trocla_key_expires,
      }

[duritong]

ok, that is an issue with the vault backend then.

Actually, it looks like the vault backend intended to use the expires option, since it deletes that option afterwards.

@fe80 I guess it should be fine to rename that?

[fe80]

Hello @duritong

Seems totally legit, that's a bug :+1: