Can't build for Electron 28.2

durs / node-activex

Node.JS Implementaion of ActiveXObject

MIT License

329 stars 62 forks source link

Can't build for Electron 28.2 #131

Closed somanuell closed 9 months ago

somanuell commented 9 months ago

Classic MS min/max macro conflict with recent V8 code...

.electron-gyp\28.2.1\include\node\v8-typed-array.h(30,70): warning C4003: not enough arguments for function-like macro invocation 'max' [c:\SAPDevelop\WORK\winax\node_modules\winax\build\node_activex.vcxproj] (compiling source file '../src/main.cpp')

Classic solution: #define NOMINMAX...

Preparing a PR!

somanuell commented 9 months ago

PR opened https://github.com/durs/node-activex/pull/132

somanuell commented 9 months ago

FIX merged in version 3.4.2