search

durs / node-activex

Node.JS Implementaion of ActiveXObject
MIT License
329 stars 62 forks source link

VT_I8/VT_UI8 support #77

Closed kuseni closed 4 years ago

kuseni commented 4 years ago

Please, add VT_I8/VT_UI8 support. Something like 

case VT_I8:
  return Number::New(isolate, by_ref ? *v.pllVal : v.llVal);
...
case VT_UI8:
  return Number::New(isolate, by_ref ? *v.pullVal : v.ullVal);

in static Local Variant2Array2(Isolate *isolate, const VARIANT &v) in utils.cpp

durs commented 4 years ago

ok, see winax@1.19.0 but long values may be truncated to double, int64 values node js not supported

чт, 21 мая 2020 г. в 20:47, kuseni notifications@github.com:

Please, add VT_I8/VT_UI8 support. Something like

case VT_I8: return Number::New(isolate, by_ref ? v.pllVal : v.llVal); ... case VT_UI8: return Number::New(isolate, by_ref ? v.pullVal : v.ullVal);

in static Local Variant2Array2(Isolate *isolate, const VARIANT &v) in utils.cpp

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/durs/node-activex/issues/77, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEMMNLZJVSR4T3H3COL5I3RSVSJ3ANCNFSM4NHAYMTA .

kuseni commented 4 years ago

No problem, safe -(2^53 - 1) .. 2^53 - 1 usually is enough (and much better than nothing). Thanks!