dusansimic / dynamic-wallpaper

Dynamic wallpaper maker for Gnome 42
GNU General Public License v2.0
151 stars 30 forks source link

Update app icon #24

Closed daudix closed 2 years ago

daudix commented 2 years ago

Same idea, different icons and colors

Alternative variants: me dusansimic DynamicWallpaper Devel me dusansimic DynamicWallpaper me dusansimic DynamicWallpaper svg1 Devel me dusansimic DynamicWallpaper svg1 me dusansimic DynamicWallpaper svg2 Devel me dusansimic DynamicWallpaper svg2

Old icon, but now it follows GNOME HIG

me dusansimic DynamicWallpaper svg3 Devel me dusansimic DynamicWallpaper svg3

All icons zip: me.dusansimic.DynamicWallpaper.zip

daudix commented 2 years ago

@dusansimic Well, what do they look like?

dusansimic commented 2 years ago

Sorry for the delayed response. I personally prefer the old icon, it's very minimal and fits nicely on the desktop. I will add the nightly variant of the icon you've made tho, thanks for that! I've been thinking about making one myself but you were faster :smile:.

Could you add add it as me.dusansimic.DynamicWallpaper.Devel.svg in the icons directory?

daudix commented 2 years ago

Ok, no problem, but how about fixed old one? (latest in list)

daudix commented 2 years ago

Added "fixed old icon" and nightly variant ;)

you can see differences on "Files changed" section

dusansimic commented 2 years ago

What exactly was changed? After inspecting it more closely it seems like you've changed the aspect ration and added some padding. Is that what you meant by following gnome hig?

Edit: I can also see that it's not centered vertically. Is that on purpose?

daudix commented 2 years ago

Yes, icons need to follow special shape, old one just not followed shape guides Here is what I talking about:

Снимок экрана от 2022-06-19 17-43-07

If you want, you can keep current one, it just a suggestion

dusansimic commented 2 years ago

I see now. I think that is what was already done by Rokwallaby (the icon creator) but I've in my infinite wisdom decided that it didn't look quite right and modified it a bit 😅.

If you want, you can keep current one, it just a suggestion No need, I'd like to follow Gnome HIG as much as possible.

Thanks for the fixes!

daudix commented 2 years ago

And thank you for understanding :)