dusansimic / dynamic-wallpaper

Dynamic wallpaper maker for Gnome 42
GNU General Public License v2.0
151 stars 30 forks source link

Add access keys/mnemonics #60

Closed rafasb0 closed 1 year ago

rafasb0 commented 1 year ago

Mudanças realizadas nos códigos em "Name", "Light Wallpaper" e "Dark Wallpaper" para promover a movimentação usando caracteres.

dusansimic commented 1 year ago

@rafasb0 thank you for your contribution! I'd just like to ask to send patch submissions in English. Even tho it's related to translations. Also, could you point me to the docs that describe what you did and why you did it?

lambdcalculus commented 1 year ago

@dusansimic Hi! This contribution was made as part of an event held at Unicamp, a Brazilian university, which is why the comment is in Portuguese (forgot to tell some people to do it in English). I helped Rafaela with the commit, so I can tell you what it does.

It just adds Access Keys (also called mnemonics) to the app, so you can now use Alt+N, Alt+L and Alt+D to navigate the app a bit more quickly with only a keyboard. Translations will need to be updated, for the record (but it's just adding an underline to some strings so you don't even need to know the language to do it).

If any further help is needed, I can help out :).

dusansimic commented 1 year ago

Sorry for lack of activity. I had a lot of work and very little free time lately.

Thank you for clarifying everything and for helping out 😁! I've just managed to push an update for the app on flathub. Translators already did fantastic work preparing for this release and I didn't want to add anything else before making the release. I'll pull this in probably some time this week or the next one so translators can add the feature. I'm not sure when will the next release be available but once it gets merged, it will definitely make it into the app :). I'll probably let all the translators know once all changes for the next release affecting the translation land on main.