search

dushkindigital / marketmap

New, clean repo for Shekhar
2 stars 0 forks source link

Map Condition enum with ebay condition id #13

Closed shekhargulati closed 12 years ago

shekhargulati commented 12 years ago

Currently in the application we were hard coding 1000 as condition id. This means that every item was NEW which is incorrect. I spend some time reading the documentation on conditionId which can be found here found here http://developer.ebay.com/devzone/xml/docs/reference/ebay/AddFixedPriceItem.html#Request.Item.ConditionID. I updated the LiberecoCondition enum with names in Ebay documentation http://developer.ebay.com/DevZone/XML/docs/WebHelp/wwhelp/wwhimpl/js/html/wwhelp.htm?context=eBay_XML_API&topic=ItemCondition. I tried creating listings with all the mentioned conditionIds but was not able to create listings with all the conditionIds. Below is the list of conditionIds I was able to create and not create.

***_Created *_** Created listing for NEW Created listing for NEW_OTHER Created listing for MANUFACTURER_REFURBISHED Created listing for SELLER_REFURBISHED Created listing for USED Created listing for PARTS_NOT_WORKING Not Created ****** Not Able to create listing for NEW_WITH_DEFECTS Condition is required for this category. This listing should contain product details from the eBay catalog. Add product details to this listing. Not Able to create listing for LIKE_NEW Condition is required for this category. This listing should contain product details from the eBay catalog. Add product details to this listing. Not Able to create listing for VERY_GOOD Condition is required for this category. This listing should contain product details from the eBay catalog. Add product details to this listing. Not Able to create listing for GOOD Condition is required for this category. This listing should contain product details from the eBay catalog. Add product details to this listing. Not Able to create listing for ACCEPTABLE Condition is required for this category. This listing should contain product details from the eBay catalog. Add product details to this listing.

shekhargulati commented 12 years ago

Some more information about listing condition can be found here http://pages.ebay.com/sellerinformation/sellingresources/itemconditionlookup.html

prp commented 12 years ago

I think it's fine for now not to support all listing conditions. It appears that some of the conditions will only become possible once we tie in listings with product details, which means that we need the mapping to eBay product categories etc., which will come at a later milestone.

Another more fundamental issue is that we don't want to attach eBay-specific conditions with a LiberecoListing. We should instead probably pick a sub-set of conditions that can be supported across a range of marketplaces. (We can still associate eBay-specific conditions with an EbayListing if we want to expose them to the user.)

(By the way, we should probably stick with the naming convention that marketplace-specific classes should include the name of the marketplace.)

shekhargulati commented 12 years ago

Thanks for your comment. I am sticking with naming convention you mentioned. I have not looked at other Marketplaces but NEW, MANUFACTURER_REFURBISHED,SELLER_REFURBISHED, PARTS_NOT_WORKING and USED looks like generic conditions. I am not sure how we can associate ebay specific conditions with EbayListing because it will mean we are asking user to enter condition of the product twice. My assumption is that user can only enter one condition. So, while creating LiberecoListing if he has specified condition as USED how will we show him other conditions when he is trying to create LiberecoListing. For now I will use the common conditionIds that I specified above in LiberecoListing. Does this make sense?

shekhargulati commented 12 years ago

I have fixed with issue as mentioned above. If you have any comments or feedback please reopen this issue.

prp commented 12 years ago

Thanks, Shekhar. I think we are on the same page.

My point about exposing ebay-specific conditions was that if we feel that one of those conditions is useful if a user lists an item on ebay, we could expose it as a special case. As you say, it would mean that we would have to ask the user specifically about it once they decide to list an item on ebay. For the given conditions above, however, I agree that it is fine to stick with the generic ones. Ticket closed.