search

dushyantsingh311 / google-api-translate-java

Automatically exported from code.google.com/p/google-api-translate-java
0 stars 0 forks source link

[changes/question] Why You didn't use enum #46

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I changed Language class to enum. I think this is better because in
Translate class I removed language validation (lines 71 to 73) because now
validation is on compiler scope. Javac check that user use correct
languages names. Now they has only limited languages list not a
unrestricted String.
I attach new version of Language and Translate files.

I interested in make more changes and re factorize code. 
pls contact with me via email.

Koziolek

Original issue reported on code.google.com by bjkuczyn...@gmail.com on 9 Mar 2009 at 8:04

Attachments:

GoogleCodeExporter commented 9 years ago 
Edit:
I added wrong files! correct versions in attachment

Original comment by bjkuczyn...@gmail.com on 9 Mar 2009 at 8:50

Attachments:

GoogleCodeExporter commented 9 years ago 
Certainly should have been an enum. Thanks for the bug report, fixed.

Original comment by rich.mid...@gmail.com on 12 Jun 2009 at 7:17

GoogleCodeExporter commented 9 years ago 
Certainly should have been an enum. Corrected, thanks for the bug report.

Original comment by rich.mid...@gmail.com on 12 Jun 2009 at 7:17