search

dushyantsingh311 / google-api-translate-java

Automatically exported from code.google.com/p/google-api-translate-java
0 stars 0 forks source link

Proxy settings #98

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I'm using a connection with a proxy, but the API does not provide for it. 

I changed the source code to enable the proxy settings with an optional 
java.net.Proxy variable. 

Is it possible to commit my code or to share it somehow? I think this could be 
a nice enhancement.

Original issue reported on code.google.com by valentin...@gmail.com on 22 Jun 2010 at 7:58

GoogleCodeExporter commented 9 years ago 
You are welcome to submit patches by attaching files to issue reports.

However, I'm of the opinion that proxy settings should really be set by the 
calling code if necessary, not on a library specifically designed for using 
Google translate so any such patch is unlikely to be included in this instance.

Original comment by rich.mid...@gmail.com on 22 Jun 2010 at 11:41

GoogleCodeExporter commented 9 years ago 
I understand what you say, but I need to use the proxy only for this single 
request, and not for the entire application. So I need to set the proxy on the 
specific URLConnection of the API's request. 

Attached you can find my changes to the GoogleAPI class.

Bye! :)

Original comment by valentin...@gmail.com on 22 Jun 2010 at 12:53

Attachments: