search

dusk-network / bls12_381

Implementation of the BLS12-381 pairing-friendly elliptic curve group with extra features needed by the Dusk-Network team
Other
19 stars 20 forks source link

Scalar derives Hash but explicitly implements PartialEq #106

Closed HDauven closed 10 months ago

HDauven commented 1 year ago

Describe the bug Scalar derives Hash but also has an explicit PartialEq implementation. Clippy doesn't like this because it wants the traits to agree on the implementation of a PartialEq.

Getting rid of our custom PartialEq implementation would mean losing the constant time equality.

Additional context Hash currently isn't being used internally on Scalar. For now, the warning has been disabled.