search

dusk-network / dusk-blockchain

Reference implementation of the DUSK Network node, written in Golang
MIT License
102 stars 47 forks source link

Send reduction concurrently without blocking votes re-propagation #1442

Closed goshawk-3 closed 2 years ago

goshawk-3 commented 2 years ago

fixes #1441

Additionally, another edge case will be addressed out of this PR (with issue https://github.com/dusk-network/dusk-blockchain/issues/1444)

codecov-commenter commented 2 years ago

Codecov Report

Merging #1442 (c216119) into master (828364b) will decrease coverage by 10.29%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1442       +/-   ##
===========================================
- Coverage   50.51%   40.22%   -10.30%     
===========================================
  Files         145      146        +1     
  Lines        7544     9646     +2102     
===========================================
+ Hits         3811     3880       +69     
- Misses       3066     5138     +2072     
+ Partials      667      628       -39
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) :arrow_down:
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) :arrow_down:
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) :arrow_down:
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) :arrow_down:
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) :arrow_down:
pkg/gql/query/transactions.go 13.43% <0.00%> (-52.55%) :arrow_down:
pkg/rpc/client/session.go 21.42% <0.00%> (-47.15%) :arrow_down:
pkg/core/consensus/reduction/aggregator.go 47.36% <0.00%> (-43.94%) :arrow_down:
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) :arrow_down:
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) :arrow_down:
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ebd6cb...c216119. Read the comment docs.