search

dusk-network / dusk-blockchain

Reference implementation of the DUSK Network node, written in Golang
MIT License
102 stars 47 forks source link

Sortition Hash is not compliant with specification #1494

Open fed-franz opened 1 year ago

fed-franz commented 1 year ago

Description createSortitionHash returns $H(round||iteration||step||seed)$, but the specification states it should be $H(seed||round||step||iteration)$.

Logically speaking, the concatenation order should follow round->step->iteration, like in the specification. Technically speaking, this does not affect correctness/security, as long as all nodes calculate the same hash.

Solutions There are two options:

  1. Leave the code unchanged and update the specifications accordingly
  2. Adapt the code to the specification
fed-franz commented 1 year ago

IMHO, I strongly believe we should change the code.

fed-franz commented 1 year ago

Mirrored Issue in rusk#907