search

dusk-network / dusk-blockchain

Reference implementation of the DUSK Network node, written in Golang
MIT License
101 stars 47 forks source link

Add `Iteration` to block header #1501

Closed herr-seppia closed 1 year ago

herr-seppia commented 1 year ago

This add iteration to the block header, including it into the hashed fields used to calculate the block hash

In addition, this PR remove step from block header certificate (since it's a duplicated info)

Resolves #1500

codecov-commenter commented 1 year ago

Codecov Report

Base: 40.18% // Head: 40.08% // Decreases project coverage by -0.11% :warning:

Coverage data is based on head (dab3d75) compared to base (57c6bbd). Patch coverage: 20.00% of modified lines in pull request are covered.

:exclamation: Current head dab3d75 differs from pull request most recent head 0e15f54. Consider uploading reports for the commit 0e15f54 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1501 +/- ## ========================================== - Coverage 40.18% 40.08% -0.11% ========================================== Files 147 147 Lines 9651 9740 +89 ========================================== + Hits 3878 3904 +26 - Misses 5144 5212 +68 + Partials 629 624 -5 ``` | [Impacted Files](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [pkg/config/genesis/config.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvbmZpZy9nZW5lc2lzL2NvbmZpZy5nbw==) | `0.00% <ø> (ø)` | | | [pkg/config/genesis/presets.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvbmZpZy9nZW5lc2lzL3ByZXNldHMuZ28=) | `69.23% <ø> (ø)` | | | [pkg/core/consensus/agreement/checkcert.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2FncmVlbWVudC9jaGVja2NlcnQuZ28=) | `6.97% <0.00%> (ø)` | | | [...nsensus/blockgenerator/candidate/blockgenerator.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2Jsb2NrZ2VuZXJhdG9yL2NhbmRpZGF0ZS9ibG9ja2dlbmVyYXRvci5nbw==) | `0.00% <0.00%> (ø)` | | | [...core/consensus/blockgenerator/candidate/genesis.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2Jsb2NrZ2VuZXJhdG9yL2NhbmRpZGF0ZS9nZW5lc2lzLmdv) | `0.00% <0.00%> (ø)` | | | [...kg/core/consensus/blockgenerator/candidate/mock.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2Jsb2NrZ2VuZXJhdG9yL2NhbmRpZGF0ZS9tb2NrLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/core/consensus/user/sortition.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL3VzZXIvc29ydGl0aW9uLmdv) | `58.25% <ø> (ø)` | | | [pkg/core/data/block/certificate.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvZGF0YS9ibG9jay9jZXJ0aWZpY2F0ZS5nbw==) | `0.00% <ø> (ø)` | | | [pkg/core/data/block/header.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvZGF0YS9ibG9jay9oZWFkZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/core/data/ipc/transactions/fixtures.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvZGF0YS9pcGMvdHJhbnNhY3Rpb25zL2ZpeHR1cmVzLmdv) | `13.76% <0.00%> (-0.21%)` | :arrow_down: | | ... and [20 more](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1501?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.