dusk-network / dusk-blockchain

Reference implementation of the DUSK Network node, written in Golang
MIT License
102 stars 47 forks source link

Fix createSortitionHash description #1512

Closed fed-franz closed 1 year ago

fed-franz commented 1 year ago

Resolves #1509

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.22 :warning:

Comparison is base (57c6bbd) 40.18% compared to head (02a7930) 39.96%.

:exclamation: Current head 02a7930 differs from pull request most recent head a888566. Consider uploading reports for the commit a888566 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1512 +/- ## ========================================== - Coverage 40.18% 39.96% -0.22% ========================================== Files 147 147 Lines 9651 9791 +140 ========================================== + Hits 3878 3913 +35 - Misses 5144 5246 +102 - Partials 629 632 +3 ``` | [Impacted Files](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [pkg/config/genesis/config.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvbmZpZy9nZW5lc2lzL2NvbmZpZy5nbw==) | `0.00% <ø> (ø)` | | | [pkg/core/consensus/agreement/checkcert.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2FncmVlbWVudC9jaGVja2NlcnQuZ28=) | `6.97% <0.00%> (ø)` | | | [...nsensus/blockgenerator/candidate/blockgenerator.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2Jsb2NrZ2VuZXJhdG9yL2NhbmRpZGF0ZS9ibG9ja2dlbmVyYXRvci5nbw==) | `0.00% <0.00%> (ø)` | | | [...core/consensus/blockgenerator/candidate/genesis.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2Jsb2NrZ2VuZXJhdG9yL2NhbmRpZGF0ZS9nZW5lc2lzLmdv) | `0.00% <0.00%> (ø)` | | | [...kg/core/consensus/blockgenerator/candidate/mock.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL2Jsb2NrZ2VuZXJhdG9yL2NhbmRpZGF0ZS9tb2NrLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/core/consensus/user/sortition.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvY29uc2Vuc3VzL3VzZXIvc29ydGl0aW9uLmdv) | `58.25% <ø> (ø)` | | | [pkg/core/data/block/block.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvZGF0YS9ibG9jay9ibG9jay5nbw==) | `8.97% <0.00%> (-1.48%)` | :arrow_down: | | [pkg/core/data/block/certificate.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvZGF0YS9ibG9jay9jZXJ0aWZpY2F0ZS5nbw==) | `0.00% <ø> (ø)` | | | [pkg/core/data/block/header.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvZGF0YS9ibG9jay9oZWFkZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/core/data/ipc/transactions/fixtures.go](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-cGtnL2NvcmUvZGF0YS9pcGMvdHJhbnNhY3Rpb25zL2ZpeHR1cmVzLmdv) | `13.76% <0.00%> (-0.21%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | | ... and [4 files with indirect coverage changes](https://codecov.io/gh/dusk-network/dusk-blockchain/pull/1512/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.