search

dusk-network / dusk-zerocaf

Zerocaf: A library built for EC operations in Zero Knowledge.
https://dusk.network/
MIT License
53 stars 11 forks source link

Files for proofs and src changes #74

Closed LukePearson1 closed 5 years ago

LukePearson1 commented 5 years ago

The main purpose of this pull request is not only to pull over the work for the finalised issue #25 but the compiler issue as shown in src/backend/mod.rs by #[cfg(not(any(feature = "u64_backend")))]; compile_error!( "no zerocaf backend cargo feature enabled! please enable one of them."

has finally been fixed so there's no longer any compiler issues. Due to the annoying issues these few lined of code were giving us, I think it is best to completely omit the old mistakes by having this merge request.

Aside from that, the rest of the additions are mostly proofs written in python and descriptions with documentation to support other aspects of the library. Whilst bearing this in mind, I feel we should add some directional indicators or hyperlinks to some parts of the library.

The commit, 729d05f is change to base point order solving and is not part of the merge requests title. This is specifically concerned with verification on the basepoint computation as well as a proof that the computed base point doesn't contain a modular square root. Additionally, it is stated which output of a modular square root operation is taken to be positive. Which is crucial for sign choice operations. However, this is only a conjecture and a formal proof will need to be created.

CPerezz commented 5 years ago

Merge conflicts have been solved.

Also, I think you should check the comments I added, especially the one related to the positiveness checking.

LukePearson1 commented 5 years ago

This pull request was closed because due to the closure of pull request No 80, where the branch was 'reset' in effect to avoid the issues which arose from Travis CI in the branch.