dusk-network / dusk-zerocaf

Zerocaf: A library built for EC operations in Zero Knowledge.
https://dusk.network/
MIT License
53 stars 11 forks source link

Refactoring docs #85

Closed LukePearson1 closed 5 years ago

LukePearson1 commented 5 years ago

This pull request is mostly covering refactoring and doing a replacement of the code in line with the new curve model, as well as a change in terms. Whether this is kept open or not, as I continue to commit is not very important. However just ensure that the same refactoring isn't done on other forks, as it would be unecessary.

Whilst perusing, I have come across 4 aspects in the code which I would like to go through with @CPerezz before making changes.


Extra work that has been done in addition to refactoring, includes:

codecov[bot] commented 5 years ago

Codecov Report

Merging #85 into ristretto-skeleton will decrease coverage by 0.02%. The diff coverage is 85.71%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           ristretto-skeleton      #85      +/-   ##
======================================================
- Coverage               98.28%   98.26%   -0.03%     
======================================================
  Files                       5        4       -1     
  Lines                    3678     2824     -854     
======================================================
- Hits                     3615     2775     -840     
+ Misses                     63       49      -14
Impacted Files Coverage Δ
src/edwards.rs 95.81% <85.71%> (-2.48%) :arrow_down:
src/backend/u64/field.rs 99.39% <0%> (-0.14%) :arrow_down:
src/ristretto.rs
src/backend/u64/scalar.rs 99.21% <0%> (+0.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1dfb49...7830003. Read the comment docs.

CPerezz commented 5 years ago

@Bounce23 can you make the PR to ristretto_skeleton branch instead to master direcly?.

Branch out from ristretto_skeleton, make the changes there, and then make the PR to the branch mentioned before please.

Otherways it's a mess to merge into master later since the docs are completely different.

LukePearson1 commented 5 years ago

I have just changed the branches. I will look at it once its in the ristretto-skeleton.