Closed LukePearson1 closed 5 years ago
This will be added to across the next 24 hours in terms of added code for the new 'path' of zerocaf.
Merging #89 into ristretto-skeleton will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## ristretto-skeleton #89 +/- ##
==================================================
Coverage 98.6% 98.6%
==================================================
Files 5 5
Lines 4015 4015
==================================================
Hits 3959 3959
Misses 56 56
Impacted Files | Coverage Δ | |
---|---|---|
src/lib.rs | 100% <ø> (ø) |
:arrow_up: |
src/ristretto.rs | 93.5% <ø> (ø) |
:arrow_up: |
src/backend/u64/scalar.rs | 99.15% <ø> (ø) |
:arrow_up: |
src/backend/u64/field.rs | 99.56% <100%> (ø) |
:arrow_up: |
src/edwards.rs | 98.79% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e416b51...5fa8d41. Read the comment docs.
If the two above comments are resolved sufficiently, feel free to merge.
This pull request is mostly covering refactoring and doing a replacement of the code in line with the new curve model, as well as a change in terms. Whether this is kept open or not, as I continue to commit is not very important. However just ensure that the same refactoring isn't done on other forks, as it would be unecessary.
Whilst perusing, I have come across 4 aspects in the code which I would like to go through with @CPerezz before making changes.
Extra work that has been done in addition to refactoring, includes: