search

dusk-network / kadcast

Official rust implementation of the Kadcast P2P protocol for ultra-efficient message dissemination within Dusk Network
Mozilla Public License 2.0
22 stars 3 forks source link

Keep nonce validation during the key creation #136

Closed herr-seppia closed 7 months ago

herr-seppia commented 8 months ago

Summary

Consider change BinaryID::from_nonce to return error if nonce is not valid

Additional context

Even if the nonce is checked externally, the current code is considered error prone (because it relies on further checks to consider the BinaryID valid)