search

dusk-network / piecrust

General purpose virtual machine for running WASM smart contracts
Mozilla Public License 2.0
22 stars 13 forks source link

rkyv version question #395

Open nekonimous opened 2 hours ago

nekonimous commented 2 hours ago

Hey,

I noticed that Piecrust and Rusk seem to have different version constraints for rkyv:

Rusk: https://github.com/dusk-network/rusk/blob/d1bcaa2fb282c56748baeb3ef5dd9d5e3086ca4e/Cargo.toml#L120

Piecrust: https://github.com/dusk-network/piecrust/blob/2a8e0b4faa7017029295e08f2660ffa90cdbe146/piecrust/Cargo.toml#L21 (while 0.7.43 is the latest release of 0.7 series)

Out of curiosity, but would it make sense to use the same version across repos here or does it not matter at all?

--

Additionally, I also noticed that rkyv recently released a new major version 0.8 that breaks backward compatibility.

Could this lead to any potential issues later down the line if you planned to upgrade with existing data?

nekonimous commented 2 hours ago

@autholykos @HDauven @miloszm