dusk-network / plonk

Pure Rust implementation of the PLONK ZKProof System done by the Dusk team
https://dusk-network.github.io/plonk
Mozilla Public License 2.0
543 stars 150 forks source link

Refactor and add tests for logic component #745

Closed moCello closed 1 year ago

moCello commented 1 year ago

Resolves #734

codecov[bot] commented 1 year ago

Codecov Report

Merging #745 (2584565) into master (e676741) will increase coverage by 0.28%. The diff coverage is 96.68%.

:exclamation: Current head 2584565 differs from pull request most recent head 8843fc6. Consider uploading reports for the commit 8843fc6 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/dusk-network/plonk/pull/745/graphs/tree.svg?width=650&height=150&src=pr&token=7JKOJ0fLuy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ```diff @@ Coverage Diff @@ ## master #745 +/- ## ========================================== + Coverage 84.70% 84.99% +0.28% ========================================== Files 53 53 Lines 4099 4078 -21 ========================================== - Hits 3472 3466 -6 + Misses 627 612 -15 ``` | [Impacted Files](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [tests/assert\_scalar.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvYXNzZXJ0X3NjYWxhci5ycw==) | `84.12% <90.00%> (ø)` | | | [tests/append\_gate.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvYXBwZW5kX2dhdGUucnM=) | `92.68% <90.90%> (+3.64%)` | :arrow_up: | | [tests/logic.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvbG9naWMucnM=) | `94.16% <97.19%> (+0.48%)` | :arrow_up: | | [tests/assert\_point.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvYXNzZXJ0X3BvaW50LnJz) | `83.05% <100.00%> (+0.59%)` | :arrow_up: | | [tests/boolean.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvYm9vbGVhbi5ycw==) | `65.00% <100.00%> (+1.84%)` | :arrow_up: | | [tests/common/mod.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvY29tbW9uL21vZC5ycw==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: | | [tests/ecc.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvZWNjLnJz) | `88.49% <100.00%> (+0.42%)` | :arrow_up: | | [tests/select\_bls.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvc2VsZWN0X2Jscy5ycw==) | `87.80% <100.00%> (+0.46%)` | :arrow_up: | | [tests/select\_point.rs](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvc2VsZWN0X3BvaW50LnJz) | `90.09% <100.00%> (+0.18%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://codecov.io/gh/dusk-network/plonk/pull/745/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Last update [e676741...8843fc6](https://codecov.io/gh/dusk-network/plonk/pull/745?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network).