dusk-network / plonk

Pure Rust implementation of the PLONK ZKProof System done by the Dusk team
https://dusk-network.github.io/plonk
Mozilla Public License 2.0
543 stars 150 forks source link

Add test and fix for panic on prove #761

Closed moCello closed 1 year ago

moCello commented 1 year ago

This fixes a panic on proof creation when the circuit to prove is larger than in the provers circuit description

codecov[bot] commented 1 year ago

Codecov Report

Merging #761 (27e22be) into master (66f8d64) will decrease coverage by 0.02%. The diff coverage is 73.91%.

:exclamation: Current head 27e22be differs from pull request most recent head 13e90ac. Consider uploading reports for the commit 13e90ac to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dusk-network/plonk/pull/761/graphs/tree.svg?width=650&height=150&src=pr&token=7JKOJ0fLuy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ```diff @@ Coverage Diff @@ ## master #761 +/- ## ========================================== - Coverage 85.07% 85.05% -0.02% ========================================== Files 56 57 +1 Lines 4343 4364 +21 ========================================== + Hits 3695 3712 +17 - Misses 648 652 +4 ``` | [Files Changed](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [src/error.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2Vycm9yLnJz) | `0.00% <0.00%> (ø)` | | | [tests/size.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvc2l6ZS5ycw==) | `75.00% <75.00%> (ø)` | | | [src/composer.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyLnJz) | `91.11% <100.00%> (+0.05%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/dusk-network/plonk/pull/761/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Last update [66f8d64...13e90ac](https://app.codecov.io/gh/dusk-network/plonk/pull/761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network).