dusk-network / plonk

Pure Rust implementation of the PLONK ZKProof System done by the Dusk team
https://dusk-network.github.io/plonk
Mozilla Public License 2.0
535 stars 148 forks source link

Fix inconsistent gate ordering #799

Closed moCello closed 8 months ago

moCello commented 8 months ago

Resolves #797

codecov[bot] commented 8 months ago

Codecov Report

Merging #799 (83e016b) into master (16145dc) will increase coverage by 0.02%. The diff coverage is 95.91%.

:exclamation: Current head 83e016b differs from pull request most recent head 812cabe. Consider uploading reports for the commit 812cabe to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dusk-network/plonk/pull/799/graphs/tree.svg?width=650&height=150&src=pr&token=7JKOJ0fLuy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ```diff @@ Coverage Diff @@ ## master #799 +/- ## ========================================== + Coverage 85.07% 85.10% +0.02% ========================================== Files 57 57 Lines 4048 4047 -1 ========================================== Hits 3444 3444 + Misses 604 603 -1 ``` | [Files](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [src/commitment\_scheme/kzg10/key.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbW1pdG1lbnRfc2NoZW1lL2t6ZzEwL2tleS5ycw==) | `84.28% <100.00%> (ø)` | | | [src/composer/builder.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL2J1aWxkZXIucnM=) | `80.43% <100.00%> (ø)` | | | [src/composer/compiler.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL2NvbXBpbGVyLnJz) | `99.44% <100.00%> (+<0.01%)` | :arrow_up: | | [src/composer/prover.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL3Byb3Zlci5ycw==) | `95.54% <100.00%> (ø)` | | | [src/permutation.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3Blcm11dGF0aW9uLnJz) | `92.83% <100.00%> (ø)` | | | [src/proof\_system/linearization\_poly.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3Byb29mX3N5c3RlbS9saW5lYXJpemF0aW9uX3BvbHkucnM=) | `99.21% <100.00%> (ø)` | | | [src/proof\_system/proof.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3Byb29mX3N5c3RlbS9wcm9vZi5ycw==) | `95.94% <100.00%> (ø)` | | | [src/proof\_system/quotient\_poly.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3Byb29mX3N5c3RlbS9xdW90aWVudF9wb2x5LnJz) | `100.00% <100.00%> (ø)` | | | [src/proof\_system/widget/arithmetic/proverkey.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3Byb29mX3N5c3RlbS93aWRnZXQvYXJpdGhtZXRpYy9wcm92ZXJrZXkucnM=) | `92.85% <100.00%> (ø)` | | | [...roof\_system/widget/ecc/curve\_addition/proverkey.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3Byb29mX3N5c3RlbS93aWRnZXQvZWNjL2N1cnZlX2FkZGl0aW9uL3Byb3ZlcmtleS5ycw==) | `85.71% <ø> (ø)` | | | ... and [13 more](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/dusk-network/plonk/pull/799/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Last update [16145dc...812cabe](https://app.codecov.io/gh/dusk-network/plonk/pull/799?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network).